opt: fix bug in stats code for inverted join#50713
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 27, 2020
Merged
opt: fix bug in stats code for inverted join#50713craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit fixes an omission in the statisticsBuilder code for inverted joins that caused some queries involving joins between two geospatial columns to fail with an internal error. In particular, the function colStatFromJoinRight needed a special case for inverted join to get a column statistic from the index side of the join, similar to the special case for lookup join. There is no release note for this PR since it fixes a bug that was introduced two days ago. Release note: None
Member
|
This change is |
sumeerbhola
approved these changes
Jun 26, 2020
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
thanks for the quick fix
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Collaborator
Author
|
TFTR! bors r+ |
Contributor
Build failed |
Collaborator
Author
|
bors r+ |
Contributor
Build failed |
Collaborator
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an omission in the
statisticsBuildercode for invertedjoins that caused some queries involving joins between two geospatial
columns to fail with an internal error. In particular, the function
colStatFromJoinRightneeded a special case for inverted join to geta column statistic from the index side of the join, similar to the
special case for lookup join.
There is no release note for this PR since it fixes a bug that was introduced
two days ago.
Release note: None