sql: update the SHOW RANGE FOR ROW command to just take index cols#50479
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 22, 2020
Merged
sql: update the SHOW RANGE FOR ROW command to just take index cols#50479craig[bot] merged 1 commit intocockroachdb:masterfrom
SHOW RANGE FOR ROW command to just take index cols#50479craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
cc @awoods187, mind playing around with this once it lands? |
solongordon
approved these changes
Jun 22, 2020
Contributor
solongordon
left a comment
There was a problem hiding this comment.
LGTM though let's give the user more help in the weird implicit columns case.
Reviewed 2 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rohany and @solongordon)
pkg/sql/sem/builtins/builtins.go, line 3332 at r1 (raw file):
return nil, errors.WithHintf( err, "columns %v are implicitly part of index %q's key and must be included",
I wonder if we can make this message clearer. It's not clear what order the columns should be provided in. Maybe it would be more helpful to provide a complete list of the columns which should be specified.
Fixes cockroachdb#41421. The SHOW RANGE FOR ROW command was difficult to use because it required the user to input all of the columns in a particular row. This PR changes the command to only require inputting the index columns now. Release note (backward-incompatible change): The SHOW RANGE FOR ROW command has been changed to take in a tuple of the row's index columns, rather than the full column set of the row.
06fb35c to
e039bac
Compare
Contributor
Author
|
Updated the message, PTAL |
solongordon
approved these changes
Jun 22, 2020
Contributor
Author
|
bors r=solongordon |
Contributor
Build failed (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41421.
The SHOW RANGE FOR ROW command was difficult to use because it required
the user to input all of the columns in a particular row. This PR
changes the command to only require inputting the index columns now.
Release note (backward-incompatible change): The SHOW RANGE FOR ROW
command has been changed to take in a tuple of the row's index columns,
rather than the full column set of the row.