base,rpc: move transport handling to rpcContext#50438
base,rpc: move transport handling to rpcContext#50438craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
|
This change is |
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 20 of 20 files at r7.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @bdarnell, @nvanbenschoten, and @tbg)
pkg/security/certificate_manager.go, line 265 at r7 (raw file):
// CACertPath returns the expected file path for the CA certificate. func (cd CertsLocator) CACertPath() string {
s/cd/cl/g
nvb
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, 20 of 20 files at r7.
Reviewable status:
pkg/rpc/pg.go, line 16 at r7 (raw file):
// LoadSecurityOptions extends a url.Values with SSL settings suitable for // the given server config. It returns true if and only if the URL
"It returns true"?
c1c0966 to
0e8fe31
Compare
tbg
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/security/certificate_manager.go, line 265 at r7 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
s/cd/cl/g
Done.
nvb
left a comment
There was a problem hiding this comment.
Reviewed 19 of 19 files at r9.
Reviewable status:
2c8714c to
a6e4242
Compare
We want to move the certificate handlers off *base.Config, onto *rpc.Context, so this is a good first step. Release note: None
This commit moves the TLS-related functionaliy that has piled up on `*base.Config` onto a dedicated helper that lives in the `rpc` package. This isn't perfect yet, but a good step forward - it is now possible to reason about the certificate names and locations without having to set up a full `CertificateManager`, and `*base.Config` has lost much of the mutable state it once had and is much closer to being an actual "config". Release note: None
|
bors r=nvanbenschoten |
Build succeeded |
This commit moves the TLS-related functionaliy that has piled up on
*base.Configonto a dedicated helper that lives in therpcpackage.This isn't perfect yet, but a good step forward - it is now possible to
reason about the certificate names and locations without having to set
up a full
CertificateManager, and*base.Confighas lost much of themutable state it once had and is much closer to being an actual
"config".
Release note: None