vendor: Bump pebble to a08efa805781318782db494653e33dc209ffd622#50280
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 17, 2020
Merged
vendor: Bump pebble to a08efa805781318782db494653e33dc209ffd622#50280craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
@petermattis does your concurrency fix need a release note as well? |
petermattis
approved these changes
Jun 16, 2020
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
LGTM
The compaction concurrency change was a performance improvement for a subset of workloads. I'm on the fence about whether it needs a release note.
Nit on the existing release note: the bug would only sometimes manifest. The way it is written now it makes it seem like it would always manifest.
Contributor
Author
|
I added |
Contributor
Author
|
CI failure seems to be unrelated to this PR, as the test also fails on master. Will merge when that's fixed. |
Changes pulled in: - 223327f23e83e69f18ad1ba45d931ed0b20f7627 internal/record: Handle ErrUnexpectedEOFs like invalid records - c1719779831f5ce6094b6366c0afe28c31b7a2c2 db: wake all waiters on cleaner.cond on state transitions - b893bb26369d8124ee11c3e0cff97a41c68022ca internal/manifest: Don't error when intra-L0 seed file is compacting - d656faf2c4567d5b23dbf079daa46d6b13d8cc29 db: tweak the compaction concurrency heuristics - f550e81e347485b8309cf8b221c67285b89d777b db: fix mergingIter corner case surrounding range tombstones - ca93fc7b74b4c87d82fe358ba3c740df16906a63 internal/metamorphic: fail tests on calls to Fatalf - bf0653a8f1b07c364b9ff91ee55da3023aed968a docs: add doc on Linux I/O profiling tools - cb9c3090f41715ddb29ff52f15562143c1a7f390 *: Add error.Wrap() call to errors from wal/manifest record reader - 330d079d4e334db1045fc932beb0fcd21c859a30 *: consistently capitalize Sublevels - fc886eca19e6b55105e609f47132699592e9d9c9 *: Enable flush splits in L0 Fixes cockroachdb#49747. Release note (bug fix): Fix a bug where an "unexpected EOF" error would be returned at startup with the pebble storage engine, if the last instance of cockroach crashed in a rare case of the write-ahead log being written to.
Contributor
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes pulled in:
Fixes #49747.
Release note (bug fix): Fix a bug where an "unexpected EOF" error would
be returned at startup with the pebble storage engine, if the last instance
of cockroach crashed in a rare case of the write-ahead log being written to.