ui: remove compactor queue graphs#50245
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 16, 2020
Merged
Conversation
Remove the compactor queue graphs from the Admin UI. They were commonly confused with storage-engine level compactions, and the compactor queue itself will (after future work) no longer be used for Pebble storage engines at all. I left the underlying metrics, assuming they'll still be useful for diangosing problems on nodes running with RocksDB. Addresses part of cockroachdb#46389. Release note (admin ui change): The 'Queues' dashboard in the Admin UI no longer shows a 'Compaction Queue' graph and the 'Queue Processing Failures' and 'Queue Processing Times' graphs no longer include the 'Compaction' queue metrics because these were commonly confused.
Member
|
This change is |
Collaborator
|
FYI @taroface |
Contributor
Author
|
TFTR! bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the compactor queue graphs from the Admin UI. They were commonly
confused with storage-engine level compactions, and the compactor queue
itself will (after future work) no longer be used for Pebble
storage engines at all.
I left the underlying metrics, assuming they'll still be useful for
diangosing problems on nodes running with RocksDB.
Release note (admin ui change): The 'Queues' dashboard in the Admin UI
no longer shows a 'Compaction Queue' graph and the 'Queue Processing
Failures' and 'Queue Processing Times' graphs no longer include the
'Compaction' queue metrics because these were commonly confused.