sql: add tests for SET DATATYPE with enum columns#50120
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 12, 2020
Merged
sql: add tests for SET DATATYPE with enum columns#50120craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
RichardJCai
reviewed
Jun 11, 2020
| statement error pq: foreign key violation: "enum_origin" row x='hello' has no match in "enum_referenced" | ||
| ALTER TABLE enum_origin ADD FOREIGN KEY (x) REFERENCES enum_referenced (x) | ||
|
|
||
| # Tests for ALTER COLUMN SET DATA TYPE. |
Contributor
There was a problem hiding this comment.
Can you add some tests where
- The conversion to enum is invalid
- enum to another enum
- maybe enum to the same enum to make sure the type equivalency check is okay and we perform a no-op.
Contributor
Author
There was a problem hiding this comment.
Done 1, 3. 2 isn't possible directly (pg doesnt allow enum -> enum casts), it needs USING EXPRESSION.
RichardJCai
approved these changes
Jun 11, 2020
Fixes cockroachdb#48728. This PR adds tests for alter column set datatype on enum columns. Release note: None
Contributor
Author
|
bors r+ |
Contributor
Build failed (retrying...) |
Contributor
Build failed (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48728.
This PR adds tests for alter column set datatype on enum columns.
Release note: None