Skip to content

geo: handle maximum decimal digits for ST_AsText#49875

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:go-geom-update
Jun 9, 2020
Merged

geo: handle maximum decimal digits for ST_AsText#49875
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:go-geom-update

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Jun 4, 2020

Resolves #48387.
Resolves #48885.

Release note (sql change): Introduce maxDecimalDigits arguments for
ST_AsText and ST_AsEWKT, which allow rounding of the decimal digits
output in the WKT representation.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@otan otan force-pushed the go-geom-update branch from cdf003a to 6a15def Compare June 4, 2020 21:19
@otan otan marked this pull request as ready for review June 4, 2020 21:21
@otan otan requested review from a team and sumeerbhola June 4, 2020 21:22
@otan otan force-pushed the go-geom-update branch 2 times, most recently from 36e35f2 to b5a8b63 Compare June 5, 2020 23:47
Copy link
Copy Markdown
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r=sumeerbhola

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

1 similar comment
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r-

VENDORING IS THE WORST

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Canceled

@otan otan force-pushed the go-geom-update branch from b5a8b63 to 2a5436f Compare June 8, 2020 22:10
@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r=sumeerbhola

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

1 similar comment
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Canceled

@otan otan force-pushed the go-geom-update branch from 2a5436f to 5250e8a Compare June 9, 2020 00:53
Release note (sql change): Introduce maxDecimalDigits arguments for
ST_AsText and ST_AsEWKT, which allow rounding of the decimal digits
output in the WKT representation.
@otan otan force-pushed the go-geom-update branch from 5250e8a to e7b0c76 Compare June 9, 2020 02:38
@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 9, 2020

bors r=sumeerbhola

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 9, 2020

Build succeeded

@craig craig bot merged commit 3e74b0d into cockroachdb:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_AsText({geometry,int4}) geo/geogfn: implement ST_AsText({geography,int4})

3 participants