Skip to content

storage: Remove extra vars from runExportToSst#49852

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
itsbilal:benchmark-exporttosst-fix
Jun 8, 2020
Merged

storage: Remove extra vars from runExportToSst#49852
craig[bot] merged 1 commit intocockroachdb:masterfrom
itsbilal:benchmark-exporttosst-fix

Conversation

@itsbilal
Copy link
Copy Markdown
Contributor

@itsbilal itsbilal commented Jun 3, 2020

A previous change (#49721) adding a benchmark for ExportToSst
left in some extra unused variables in a helper method. This
change cleans that up.

Release note: None.

@itsbilal itsbilal requested review from pbardea and petermattis June 3, 2020 21:52
@itsbilal itsbilal self-assigned this Jun 3, 2020
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsbilal itsbilal force-pushed the benchmark-exporttosst-fix branch from f6748a3 to ea1293c Compare June 3, 2020 22:31
@itsbilal
Copy link
Copy Markdown
Contributor Author

itsbilal commented Jun 3, 2020

No change amend to get CI to build.

@itsbilal itsbilal force-pushed the benchmark-exporttosst-fix branch from ea1293c to 23c0e09 Compare June 4, 2020 16:13
A previous change (cockroachdb#49721) adding a benchmark for ExportToSst
left in some extra unused variables in a helper method. This
change cleans that up.

Release note: None.
@itsbilal itsbilal force-pushed the benchmark-exporttosst-fix branch from 23c0e09 to 4f38f0e Compare June 4, 2020 23:07
@itsbilal
Copy link
Copy Markdown
Contributor Author

itsbilal commented Jun 8, 2020

Only test failure is #49747 .

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Build succeeded

@craig craig bot merged commit 685194e into cockroachdb:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants