sql: disallow cross database type references#49841
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 8, 2020
Merged
sql: disallow cross database type references#49841craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
CC @solongordon to start taking a look at UDT stuff. cc @ajwerner @lucy-zhang if you have any opinions on this/ have different opinions how to accomplish this. |
74df81d to
ad58590
Compare
otan
reviewed
Jun 4, 2020
otan
approved these changes
Jun 5, 2020
Contributor
otan
left a comment
There was a problem hiding this comment.
LGTM -- one naming suggestion and one comment nit
Fixes cockroachdb#49809. This PR disallows using types from other databases in tables. This makes certain behavior (like `DROP TYPE`) more predictable in their effects, as well as unblocking some work for supporting user defined types in `cockroach dump`. Release note (sql change): Referencing types across databases has been disabled.
Contributor
Author
|
TFTR! bors r=otan |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49809.
This PR disallows using types from other databases in tables. This makes
certain behavior (like
DROP TYPE) more predictable in their effects,as well as unblocking some work for supporting user defined types in
cockroach dump.Release note (sql change): Referencing types across databases has been
disabled.