cloud: fixes GCS test simulating download interrupts#49840
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jun 8, 2020
Merged
cloud: fixes GCS test simulating download interrupts#49840craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
…rrupts TestAntagonisticRead simulates download interrupts for the google cloud storage reader by "randomly" injecting low level errors. There was a small bug whereby we were allowing more errors to be injected than the total number of retries in the GCS ReadFile method. This would cause the test to fail. Release Note: None
The constant `maxNoProgressReads` governs how many Read attempts we can go without receiving any bytes. Previously, our conditions were allowing one more than the constant value because of the retry counter being zero-indexed. This should not have any impact on the logic. Release Note: None
Member
|
This change is |
Contributor
Author
|
The test is still disabled, but managed to run it a 1000 times without failures. |
miretskiy
reviewed
Jun 3, 2020
Contributor
miretskiy
left a comment
There was a problem hiding this comment.
I don't usually make off by 2 errors; but when I do, I do it in tests
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @miretskiy)
Contributor
Author
|
TFTR! bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.