opt: ON UPDATE cascades for Upsert#49804
Conversation
|
This change is |
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
pkg/sql/logictest/testdata/logic_test/cascade, line 3910 at r1 (raw file):
statement ok UPSERT INTO parent VALUES (1, 1)
Consider adding a comment to explain what this is testing
Making some updates that were made only to the `cascade` version. Release note: None
This change implements ON UPDATE actions for Upsert operations. The existing machinery for Update can be used without modification. Release note: None
c1c3703 to
185c0ab
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/cascade, line 3910 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
Consider adding a comment to explain what this is testing
Done. I also added a couple of more tests and added (in a separate commit) some changes that were made only to the cascade file.
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r2, 8 of 8 files at r3.
Reviewable status:
|
bors r+ |
Timed out |
|
bors r+ |
Merge conflict (retrying...) |
Build succeeded |
This change implements ON UPDATE actions for Upsert operations. The existing
machinery for Update can be used without modification.
Release note: None