Reviewed 10 of 10 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @otan)

docs/generated/sql/functions.md, line 668 at r1 (raw file):

<tbody>
<tr><td><a name="st_area"></a><code>st_area(geography: geography) &rarr; <a href="float.html">float</a></code></td><td><span class="funcdesc"><p>Returns the area of the given geography in meters^2. Uses a spheroid to perform the operation.</p>
<p>This function utilizes the S2 library for spherical calculations.</p>

shouldn't this say "utilizes the GeographicLib library for spheroid calculations"?

docs/generated/sql/functions.md, line 748 at r1 (raw file):

<tr><td><a name="st_dwithin"></a><code>st_dwithin(geography_a: geography, geography_b: geography, distance: <a href="float.html">float</a>) &rarr; <a href="bool.html">bool</a></code></td><td><span class="funcdesc"><p>Returns true if any of geography_a is within distance meters of geography_b. Uses a spheroid to perform the operation.</p>
<p>The calculations performed are have a precision of 1cm.</p>
<p>This function utilizes the GeographicLib library for spheroid calculations.</p>

this should also say that it uses S2 for finding the closest points on the sphere.

docs/generated/sql/functions.md, line 820 at r1 (raw file):

</span></td></tr>
<tr><td><a name="st_length"></a><code>st_length(geography: geography) &rarr; <a href="float.html">float</a></code></td><td><span class="funcdesc"><p>Returns the length of the given geography in meters. Uses a spheroid to perform the operation.</p>
<p>This function utilizes the S2 library for spherical calculations.</p>

shouldn't this be "utilizes the GeographicLib library for spheroid calculations"

docs/generated/sql/functions.md, line 915 at r1 (raw file):

</span></td></tr>
<tr><td><a name="st_perimeter"></a><code>st_perimeter(geography: geography) &rarr; <a href="float.html">float</a></code></td><td><span class="funcdesc"><p>Returns the perimeter of the given geography in meters. Uses a spheroid to perform the operation.</p>
<p>This function utilizes the S2 library for spherical calculations.</p>

ditto

pkg/sql/sem/builtins/geo_builtins.go, line 53 at r1 (raw file):

ib.libraryUsage&usesGEOS

Does go fmt remove the space around the &? If not, I'd prefer to have that space since it makes it easier to spot the operator.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @sumeerbhola)

docs/generated/sql/functions.md, line 668 at r1 (raw file):

Done.

docs/generated/sql/functions.md, line 748 at r1 (raw file):

Done.

docs/generated/sql/functions.md, line 820 at r1 (raw file):

Done.

docs/generated/sql/functions.md, line 915 at r1 (raw file):

Done.
Done.

pkg/sql/sem/builtins/geo_builtins.go, line 53 at r1 (raw file):

yeah this is a gofmt thing.

Reviewed 6 of 6 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan and @sumeerbhola)

pkg/sql/sem/builtins/geo_builtins.go, line 38 at r2 (raw file):

const usesSpheroidMessage = " Uses a spheroid to perform the operation."
const spheroidDistanceMessage = `"\n\nWhen operating on a spheroid, this function will use the sphere to calculate ` +
	`the closest two points using S2. The spheroid distance is calculated of these two points using GeographicLib. ` +

nit: The spheroid distance between these two points is calculated using GeographicLib

(simpler sentence structure)

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @sumeerbhola)

pkg/sql/sem/builtins/geo_builtins.go, line 38 at r2 (raw file):

Done.