roachtest: jobs/mixed-versions applies from release 20.1.0#48515
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 7, 2020
Merged
roachtest: jobs/mixed-versions applies from release 20.1.0#48515craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
tbg
approved these changes
May 7, 2020
Member
tbg
left a comment
There was a problem hiding this comment.
Mind giving a reason for the MinVersion?
Fixes cockroachdb#48141. Release note: none.
spaskob
commented
May 7, 2020
Contributor
Author
spaskob
left a comment
There was a problem hiding this comment.
Changed the PR description and added a comment in the code.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
Contributor
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs infrastructure was unstable prior to 20.1 in terms of the behavior
of
PAUSE/CANCEL JOBcommands which were best effort and relied on thejob itself to detect the request. These were fixed by introducing new job
state machine states
Status{Pause,Cancel}Requested. This test purposeis to to test the state transitions of jobs from paused to resumed and
vice versa in order to detect regressions in the work done for 20.1.
Fixes #48141.
Release note: none.