builtins: add ST_<Shape>FromWKB and ST_<Shape>FromText functions#48441
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 7, 2020
Merged
builtins: add ST_<Shape>FromWKB and ST_<Shape>FromText functions#48441craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
sumeerbhola
approved these changes
May 6, 2020
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/sem/builtins/geo_builtins.go, line 320 at r1 (raw file):
"st_multilinestringfromtext": geometryFromTextCheckShapeBuiltin(geopb.Shape_MultiLineString), "st_multilinestringfromwkb": geometryFromWKBCheckShapeBuiltin(geopb.Shape_MultiLineString), // missing from PostGIS "st_multipointfromtext": geometryFromTextCheckShapeBuiltin(geopb.Shape_MultiPoint), // SRID version missing form PostGIS
s/form/from/
Release note (sql change): Added builtins allowing parsing text and wkb all supported shapes, e.g. `ST_PointFromWKB`, `ST_PointFromText`, which return NULL if the WKT/EWKT/WKB do not match the shape provided.
Contributor
Author
|
bors r=sumeerbhola |
Contributor
Build succeeded |
This was referenced May 13, 2020
This was referenced May 13, 2020
This was referenced Jul 17, 2020
This was referenced Feb 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note (sql change): Added builtins allowing parsing text and wkb
all supported shapes, e.g.
ST_PointFromWKB,ST_PointFromText, whichreturn NULL if the WKT/EWKT/WKB do not match the shape provided.