kvserver: improve test #48185
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 4, 2020
Merged
Conversation
Contributor
Author
|
just the last commit |
Member
|
This change is |
A test seems to have been confused about what clock controls the inactivity determination for follower inactivity. It was trying to use a manual clock which had no effect, because the inactivity is based on timeutil.Now(). Fixes cockroachdb#33654. Release note: None
88a9ff2 to
c1f6b60
Compare
tbg
approved these changes
May 1, 2020
|
❌ The GitHub CI (Cockroach) build has failed on c1f6b604. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
andreimatei
commented
May 4, 2020
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test seems to have been confused about what clock controls the
inactivity determination for follower inactivity. It was trying to use a
manual clock which had no effect, because the inactivity is based on
timeutil.Now().
Fixes #33654.
Release note: None