serverpb: introduce OptionalStatusServer#48143
Merged
craig[bot] merged 4 commits intocockroachdb:masterfrom Apr 29, 2020
Merged
serverpb: introduce OptionalStatusServer#48143craig[bot] merged 4 commits intocockroachdb:masterfrom
craig[bot] merged 4 commits intocockroachdb:masterfrom
Conversation
Avoid reaching into statusServer. Release note: None
Member
|
This change is |
This comment has been minimized.
This comment has been minimized.
Avoid having to reach into statusServer from inside SQL server setup. Release note: None
This is possible thanks to the previous two commits. Release note: None
Wrap StatusServer in an option type for use in SQL, replacing an earlier more ad-hoc (and less comprehensible) wrapper. Release note: None
asubiotto
approved these changes
Apr 29, 2020
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 4 of 4 files at r2, 3 of 3 files at r3, 12 of 12 files at r4.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Member
Author
|
TFTR! bors r=asubiotto |
Contributor
Build failed (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap StatusServer in an option type for use in SQL, replacing
an earlier more ad-hoc (and less comprehensible) wrapper.
Release note: None