Skip to content

jobs: Send results to the client when job completes#47783

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
miretskiy:flake
Apr 22, 2020
Merged

jobs: Send results to the client when job completes#47783
craig[bot] merged 1 commit intocockroachdb:masterfrom
miretskiy:flake

Conversation

@miretskiy
Copy link
Copy Markdown
Contributor

@miretskiy miretskiy commented Apr 21, 2020

Fixes #45337

Fix a race between job completion and sending the result
of the job to the client.

@miretskiy miretskiy requested a review from ajwerner April 21, 2020 18:31
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Apr 21, 2020

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4c07cfed.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4c07cfed.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4c07cfed.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4c07cfed.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4c07cfed.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4b3b2b59.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

ajwerner
ajwerner approved these changes Apr 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 21, 2020

❌ The GitHub CI (Cockroach) build has failed on 4b3b2b59.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

jobs: Send results to the client when job completes
6930984 
Fixes cockroachdb#45337

Fix a race between job completion and sending the result
of the job to the client.
@miretskiy miretskiy mentioned this pull request Apr 22, 2020
Closed
@miretskiy
Copy link
Copy Markdown
Contributor Author

miretskiy commented Apr 22, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 22, 2020

Build succeeded

@craig craig bot merged commit a3f41f5 into cockroachdb:master Apr 22, 2020
@miretskiy miretskiy mentioned this pull request Jun 17, 2020
Closed
@adityamaru adityamaru mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajwerner ajwerner ajwerner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ccl/workloadccl/allccl: TestAllRegisteredImportFixture failed

3 participants

@miretskiy @cockroach-teamcity @ajwerner