roachtest: add stmt_timeout to consistency checks#47746
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 21, 2020
Merged
roachtest: add stmt_timeout to consistency checks#47746craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Context cancellation doesn't do anything since lib/pq uses the Postgres cancellation protocol which we don't implement. See discussion on: cockroachdb#34520 The TL;DR is that we ought to be using pgx instead, which would just close the underlying conn on cancellation which is just what we want here. Release note: None
Member
|
This change is |
knz
approved these changes
Apr 21, 2020
Member
Author
|
bors r=knz |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context cancellation doesn't do anything since lib/pq uses the Postgres
cancellation protocol which we don't implement. See discussion on:
#34520
The TL;DR is that we ought to be using pgx instead, which would just
close the underlying conn on cancellation which is just what we want
here.
Release note: None