pgwire: ensure the conn is always closed even in tests#47700
pgwire: ensure the conn is always closed even in tests#47700craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes a regression introduced in cockroachdb#45193. Release note: None
|
This change is |
tbg
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix! How did the test get flaky as a result of this?
The code is intending to do Without this server-side close, when the test shuts down, the server-side conn is still open. Then the client initiates the conn teardown and sends a packet to the server, but because the server is shutting down it does not respond and the client gets a timeout. The reason why it's flaky is that most of the times the client is able to send its shutdown request to the test server and get a response before the server is so far in the shutdown that it doesn't respond any more. |
|
bors r=tbg |
Build succeeded |
Fixes #46252
Fixes a regression introduced in #45193.
Release note: None