Skip to content

roachtest: bump tpchvec slowness threshold#47134

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:bump-tpchvec
Apr 14, 2020
Merged

roachtest: bump tpchvec slowness threshold#47134
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:bump-tpchvec

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

@yuzefovich yuzefovich commented Apr 7, 2020 •
edited
Loading

This bumps the failure slowness threshold from 15% to 20%.

Fixes: #47118.

Release note: None

@yuzefovich
roachtest: bump tpchvec slowness threshold
dbb8aa6 
This bump the failure slowness threshold from 15% to 20%.

Release note: None
@yuzefovich yuzefovich requested a review from jordanlewis April 7, 2020 17:01
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Apr 7, 2020

This change is Reviewable

@jordanlewis
Copy link
Copy Markdown
Member

jordanlewis commented Apr 7, 2020

Hmm... I'm unconvinced by this change. We should figure out a way to not have 20% slower queries with vectorized. If that means we need to change what plan is getting generated with materializers/columnarizers, that's what we should do.

@yuzefovich
Copy link
Copy Markdown
Member Author

yuzefovich commented Apr 7, 2020

I don't think we can make such decision on the execution side without the optimizer support. How can we know whether it's worth vectorizing a particular plan without any cost model?

@yuzefovich
Copy link
Copy Markdown
Member Author

yuzefovich commented Apr 7, 2020 •
edited
Loading

This query does meet the vectorize_row_count_threshold, so our simple heuristic thinks that it's worth vectorizing it, but it turns out wrong in this case. I don't think we can do anything about it in 20.1 release. I hope it will be addressed, though, in 20.2 time frame.

@yuzefovich yuzefovich requested a review from asubiotto April 13, 2020 16:35
asubiotto
asubiotto reviewed Apr 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the best thing to do right now is bump the slowness threshold.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)

asubiotto
asubiotto approved these changes Apr 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)

@yuzefovich
Copy link
Copy Markdown
Member Author

yuzefovich commented Apr 14, 2020

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 14, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 14, 2020

Build succeeded

@craig craig bot merged commit ea7c459 into cockroachdb:master Apr 14, 2020
@yuzefovich yuzefovich deleted the bump-tpchvec branch April 14, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordanlewis jordanlewis Awaiting requested review from jordanlewis

1 more reviewer

@asubiotto asubiotto asubiotto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

roachtest: tpchvec/perf failed

4 participants

@yuzefovich @cockroach-teamcity @jordanlewis @asubiotto