backupccl: stop including system db as complete in full cluster backup#47092
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 7, 2020
Merged
Conversation
Member
|
This change is |
dt
approved these changes
Apr 6, 2020
ef3801b to
f7033c6
Compare
Contributor
Author
|
I want to eventually follow this up with automated testing, but want that testing to be such that it generally exercises backups with revision history in general. I've tested that it fixes the issue with manual testing and don't want the automated testing to hold up the RC. Merging this as is for now. TFTR! |
Contributor
|
Already running a review |
|
❌ The GitHub CI (Cockroach) build has failed on f7033c60. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan. |
Contributor
Build failed |
|
❌ The GitHub CI (Cockroach) build has failed on f7033c60. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan. |
When we perform a full-cluster backup we were including the system database as a "complete database", however full cluster backup only backs up a subset of the tables in the system table. This led to bugs around taking several backups with revision history since we would look for changes in all table descriptors for system tables, but we should have only been looking for differences in system tables that were backed up. Release justification: fixes release blocker. Release note (bug fix): in some cases where system tables have changed, incremental, full-cluster BACKUPs with revision history were sometimes incorrectly disallowed.
f7033c6 to
ee6a8fd
Compare
Contributor
Author
|
Hit some flakes, let's try again |
Contributor
Build failed (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we perform a full-cluster backup we were including the system
database as a "complete database", however full cluster backup only
backs up a subset of the tables in the system table.
This led to bugs around taking several backups with revision history
since we would look for changes in all table descriptors for system
tables, but we should have only been looking for differences in system
tables that were backed up.
Fixes #47050.
Release justification: fixes release blocker.
Release note (bug fix): in some cases where system tables have changed,
incremental, full-cluster BACKUPs with revision history were sometimes
incorrectly disallowed.