config/zonepb: fix typo in DefaultSystemZoneConfig#46953
config/zonepb: fix typo in DefaultSystemZoneConfig#46953craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
a775625 to
4b16929
Compare
nvb
left a comment
There was a problem hiding this comment.
DefaultSystemZoneConfig using DefaultZoneConfig so that we a) would have a harder time making these kinds of mistakes and b) would be more explicit about how we want the system zone configs to differ from the rest of the zone configs. A casual reader might not have even thought this was a mistake if they didn't notice the comment. I'll defer to you.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
4b16929 to
e36cc88
Compare
ajwerner
left a comment
There was a problem hiding this comment.
Good suggestion. Done.
Reviewable status:
e36cc88 to
0bc64c5
Compare
|
It does mean though that if someone creates a cluster using a beta version and then upgrades, they may run into problems. Do we want to care about that? |
This change fixes a typo that made the default system zone config gigabytes instead of megabytes. Fortunately this was both not released in an official release and also system ranges aren't generally gigantic. Nevertheless, this is pretty egregious. Release note: None
0bc64c5 to
ad9042e
Compare
|
bors r=nvanbenschoten
Maybe yes but anything we do can be follow up. |
Build failed (retrying...) |
Build succeeded |
This change fixes a typo that made the default system zone config gigabytes
instead of megabytes. Fortunately this was both not released in an official
release and also system ranges aren't generally gigantic.
Nevertheless, this is pretty egregious.
Release note: None