Skip to content

kv/kvserver: mv testdata/lock_table/add_discovered out of pkg/storage#46631

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/lockTableTest
Mar 27, 2020
Merged

kv/kvserver: mv testdata/lock_table/add_discovered out of pkg/storage#46631
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/lockTableTest

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Mar 26, 2020

This testdata file was added in #45601. That skewed with the mass package rename.

Release justification: testing only

@nvb nvb requested a review from sumeerbhola March 26, 2020 17:34
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

This testdata file was added in cockroachdb#45601. That skewed with the package
rename.

Release justification: testing only
@nvb nvb force-pushed the nvanbenschoten/lockTableTest branch from 5f1668d to a474490 Compare March 26, 2020 22:35
Copy link
Copy Markdown
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Mar 27, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 27, 2020

Build failed

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Mar 27, 2020

Flaked on #44732.

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 27, 2020

Build succeeded

@craig craig bot merged commit d8cef26 into cockroachdb:master Mar 27, 2020
@nvb nvb deleted the nvanbenschoten/lockTableTest branch March 30, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants