Skip to content

kv: re-enable merge queue in TestSplitTriggerRaftSnapshotRace#46433

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/reenableTestSplitTriggerRaftSnapshotRace
Mar 24, 2020
Merged

kv: re-enable merge queue in TestSplitTriggerRaftSnapshotRace#46433
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/reenableTestSplitTriggerRaftSnapshotRace

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Mar 23, 2020

The merge queue was disabled in this test by df26cf6 due to the bug
found in #32784. That bug was fixed by #33312, so we can address the
TODO and re-enable merges in the test.

Release note: None
Release justification: test only

The merge queue was disabled in this test by df26cf6 due to the bug
found in cockroachdb#32784. That bug was fixed by cockroachdb#33312, so we can address the
TODO and re-enable merges in the test.

Release note: None
Release justification: test only
@nvb nvb requested a review from andreimatei March 23, 2020 20:17
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Mar 23, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 23, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 24, 2020

Build succeeded

@craig craig bot merged commit 21e6fa6 into cockroachdb:master Mar 24, 2020
@nvb nvb deleted the nvanbenschoten/reenableTestSplitTriggerRaftSnapshotRace branch March 30, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants