deflake TestStoreRangeMergeRaftSnapshot by using a manual clock#46373
Merged
craig[bot] merged 1 commit intomasterfrom Mar 21, 2020
Merged
deflake TestStoreRangeMergeRaftSnapshot by using a manual clock#46373craig[bot] merged 1 commit intomasterfrom
craig[bot] merged 1 commit intomasterfrom
Conversation
Member
|
This change is |
Author
|
I suspect the reason that a real-time clock causes this test to be flaky is that the timestamps on the SSTs no longer align, but haven't verified that this is what was causing the test to fail. |
tbg
approved these changes
Mar 20, 2020
Author
|
bors r=tbg |
Contributor
Build failed |
Author
|
bors r=tbg |
Contributor
Build failed |
…t of \#45984, which changed the behavior of multiTestContext to use a real-time clock if it wasn't explicitly set to a manual clock. Release justification: Deflake test in non-production code. Release note: None.
ffc1eef to
1a12a9a
Compare
Author
|
bors r=tbg |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test became flaky after #45984, which changed the behavior of multiTestContext to use a real-time clock if it wasn't explicitly set to a manual clock.
Fixes #46192.
Release justification: Deflake test in non-production code.
Release note: None.