cli: allow demo to work if TZ db not available#46178
Closed
ajwerner wants to merge 1 commit intocockroachdb:masterfrom
Closed
cli: allow demo to work if TZ db not available#46178ajwerner wants to merge 1 commit intocockroachdb:masterfrom
demo to work if TZ db not available#46178ajwerner wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This PR is a follow-up to cockroachdb#45680 to re-enable `cockroach demo` even if the tz db is not available. Demo should not force users into workarounds that are vague and poorly documented. Release justification: low risk, high benefit changes to existing functionality Release note: None
Member
|
This change is |
Contributor
Author
|
I left the release note empty because the original one didn't mention demo and for |
Contributor
|
Are you sure about this? If the time-related results are wrong. isn't that going to give a poor impression of CockroachDB to demo users, who presumably are getting their first impressions from that? |
Contributor
Author
|
I typed it as a means for discussion. @jordanlewis expressed doubts about the previous behavior. I’m fine abandoning this too. Let’s get @awoods187 involved in the decision making. |
Contributor
|
Should be obsolete as of #56634! I'm going to close this, feel free to reopen if it does not address the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #45680 to re-enable
cockroach demoeven if thetz db is not available. Demo should not force users into workarounds that
are vague and poorly documented.
Release justification: low risk, high benefit changes to existing functionality
Release note: None