docgen: update savepoint-related definitions, bnfs#46048
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 16, 2020
Merged
docgen: update savepoint-related definitions, bnfs#46048craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
|
LGTM but please update the commit message and PR description to link to the proper PR - the number #45974 you used is not the correct one . |
This change updates the syntax diagram definitions and generated BNF for several SAVEPOINT-related statements, specifically: - Add the SHOW SAVEPOINT STATUS statement to the list of syntax diagrams generated by pkg/cmd/docgen - Add the SHOW SAVEPOINT STATUS BNF file to the other generated BNF files - Update ROLLBACK TO SAVEPOINT to note that the savepoint name does not have to be 'cockroach_restart' It uses the changes in cockroachdb#45794, which enabled docgen for SHOW SAVEPOINT STATUS. It is part of the work surrounding cockroachdb#45566, which added preliminary SQL savepoints support. Release justification: low-risk update to documentation diagrams Release note: None
Collaborator
Author
Done, sorry for the transposition typo! |
Contributor
|
thanks go ahead |
Collaborator
Author
|
bors r+ |
Contributor
Build failed (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the syntax diagram definitions and generated BNF for
several SAVEPOINT-related statements, specifically:
Add the SHOW SAVEPOINT STATUS statement to the list of syntax diagrams
generated by pkg/cmd/docgen
Add the SHOW SAVEPOINT STATUS BNF file to the other generated BNF
files
Update ROLLBACK TO SAVEPOINT to note that the savepoint name does not
have to be 'cockroach_restart'
It uses the changes in #45794, which enabled docgen for SHOW SAVEPOINT
STATUS.
It is part of the work surrounding #45566, which added preliminary SQL
savepoints support.
Release justification: low-risk update to documentation diagrams
Release note: None