colexec: fix hash aggregator with nulls#45913
Merged
yuzefovich merged 1 commit intocockroachdb:masterfrom Mar 9, 2020
Merged
Conversation
Member
|
This change is |
Previously, we were incorrectly handling the matching of NULL values in the grouping columns - we would short circuit only if only one of the values is NULL. However, in case when both values are NULLs we also know that they are not different. (Previously, we would be comparing the garbage values that happened to be in the column cells corresponding to NULL values in question.) Release note: None
cefb3bf to
3c200c2
Compare
Azhng
approved these changes
Mar 9, 2020
complete! 1 of 0 LGTMs obtained (waiting on
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were incorrectly handling the matching of NULL values in
the grouping columns - we would short circuit only if only one of the
values is NULL. However, in case when both values are NULLs we also know
that they are not different. (Previously, we would be comparing the
garbage values that happened to be in the column cells corresponding to
NULL values in question.)
Fixes: #45905.
Release note: None