Skip to content

opt: fix bug when WITH was used inside WITH RECURSIVE#45877

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
RaduBerinde:fix-with-frame
Mar 11, 2020
Merged

opt: fix bug when WITH was used inside WITH RECURSIVE#45877
craig[bot] merged 1 commit intocockroachdb:masterfrom
RaduBerinde:fix-with-frame

Conversation

@RaduBerinde
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde commented Mar 9, 2020

We were incorrectly building the inner CTE above the recursive CTE.

Fixes #45869.

Release note (bug fix): fixed query errors in cases where a CTE is used inside a
recursive CTE.

Release justification: Category 2: Bug fixes and low-risk updates to new functionality.

@RaduBerinde RaduBerinde requested a review from andy-kimball March 9, 2020 12:47
@RaduBerinde RaduBerinde requested a review from a team as a code owner March 9, 2020 12:47
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

We were incorrectly building the inner CTE above the recursive CTE.

Fixes cockroachdb#45869.

Release note (bug fix): fixed query errors in cases where a CTE is used inside a
recursive CTE.

Release justification: Category 2 (bug fixes and low-risk updates to new functionality).
Copy link
Copy Markdown
Contributor

@andy-kimball andy-kimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball)

@RaduBerinde
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 11, 2020

Build failed

@RaduBerinde
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 11, 2020

Build succeeded

@craig craig bot merged commit e70c4ee into cockroachdb:master Mar 11, 2020
@RaduBerinde RaduBerinde deleted the fix-with-frame branch March 12, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opt: Unexpected error when using recursive CTE

3 participants