Skip to content

kvserver,kv: move bulk, cloud, and replace kv/*.go#45873

Merged
tbg merged 14 commits intocockroachdb:masterfrom
tbg:mv-cloud
Mar 9, 2020
Merged

kvserver,kv: move bulk, cloud, and replace kv/*.go#45873
tbg merged 14 commits intocockroachdb:masterfrom
tbg:mv-cloud

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Mar 9, 2020

pkg/kvserver/bulk will move to pkg/kv/bulk, pkg/kvserver/cloud becomes pkg/storage/cloud, and pkg/kv/*.go becomes the pkg/kv/kvclient/kvcoord package. pkg/kv becomes filed with the contents of pkg/internal/client.

100% mechanical.

tbg added 4 commits March 9, 2020 11:36
Pure code movement, does not compile.

Release note: None
@tbg tbg requested a review from dt March 9, 2020 10:49
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

tbg added 3 commits March 9, 2020 11:52
TestForbiddenDeps trips over these empty directories, so make them
trivial Go packages. They will fill with live shortly anyway.

Release note: None
@tbg tbg changed the title kvserver: move bulk and cloud kvserver,kv: move bulk, cloud, and kv/*.go Mar 9, 2020
tbg added 4 commits March 9, 2020 12:03
Release note: None
Not amending the commit since it already skews.

Release note: None
@tbg tbg requested review from a team as code owners March 9, 2020 11:12
@tbg tbg changed the title kvserver,kv: move bulk, cloud, and kv/*.go kvserver,kv: move bulk, cloud, and replace kv/*.go Mar 9, 2020
tbg added 3 commits March 9, 2020 12:48
Test needed an updated package name.

Release note: None
Needed to adjust relative paths.

Release note: None
Release note: None
@tbg tbg merged commit e0ca60f into cockroachdb:master Mar 9, 2020
@tbg tbg deleted the mv-cloud branch March 9, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants