sql: move validation of primary key existence to TableCollection#45765
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 6, 2020
Merged
sql: move validation of primary key existence to TableCollection#45765craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
|
This LGTM (aside from the lint failure) |
To support `ADD/DROP PRIMARY KEY` operations within a single transaction, we had added a step in the `connExecutor` to verify that all tables modified in the transaction have a primary key before we commit the transaction. This was done by examining `SchemaChanger`s queued in the transaction in `extraTxnState`. To ease the process of removing `SchemaChanger`s from `extraTxnState` as part of moving them to jobs, this PR moves the validation implementation to a method on `TableCollection` that examines all modified tables. Release note: None
Author
|
I also got a |
Author
|
TFTR bors r+ |
Contributor
Build failed (retrying...) |
Contributor
Build failed (retrying...) |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support
ADD/DROP PRIMARY KEYoperations within a singletransaction, we had added a step in the
connExecutorto verify thatall tables modified in the transaction have a primary key before we
commit the transaction. This was done by examining
SchemaChangersqueued in the transaction in
extraTxnState. To ease the process ofremoving
SchemaChangers fromextraTxnStateas part of moving them tojobs, this PR moves the validation implementation to a method on
TableCollectionthat examines all modified tables.Release note: None