jobs: add log tags on contexts for Resume and OnFailOrCancel hooks#45728
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 5, 2020
Merged
jobs: add log tags on contexts for Resume and OnFailOrCancel hooks#45728craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Author
|
@spaskob I'm proposing this as an alternative to including One slight downside is that now there are multiple formats surrounding job IDs in logs, but in practice we should grep for just the job ID itself. |
dt
approved these changes
Mar 4, 2020
spaskob
approved these changes
Mar 4, 2020
Contributor
spaskob
left a comment
There was a problem hiding this comment.
Thank you, this is awesome!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @dt and @spaskob)
Author
|
bors r+ |
Contributor
Build failed (retrying...) |
Author
|
bors flake bors r+ |
This PR adds a log tag with the job ID (`job=...`) to the contexts passed to `Resume()` and `OnFailOrCancel()`, so that logs emitted from those job hooks can be associated with the job. We should probably expand the scope of using these log tags to other parts of the job registry to avoid the overhead of manually including job IDs in log messages. This is meant to be a starting point and have a limited, well-defined scope. Release note (general change): Logs emitted from jobs are now tagged with the job ID to improve visibility and aid debugging.
86b89aa to
6f39a24
Compare
Author
|
It was the CLA assistant... bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a log tag with the job ID (
job=...) to the contextspassed to
Resume()andOnFailOrCancel(), so that logs emitted fromthose job hooks can be associated with the job.
We should probably expand the scope of using these log tags to other
parts of the job registry to avoid the overhead of manually including
job IDs in log messages. This is meant to be a starting point and have a
limited, well-defined scope.
Release note (general change): Logs emitted from jobs are now tagged
with the job ID to improve visibility and aid debugging.