sql: add more detailed test for operations during a primary key change#45655
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 11, 2020
Merged
sql: add more detailed test for operations during a primary key change#45655craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
cc @lucy-zhang can you take a look at this? |
|
Yeah, will do. Would you mind just rebasing this on master and making sure it still works, now that the schema change job changes are in? |
6ac5ad1 to
fd2f458
Compare
Contributor
Author
|
Alright, rebased and everything passed |
thoszhang
approved these changes
Mar 11, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rohany)
pkg/sql/schema_changer_test.go, line 2476 at r1 (raw file):
CREATE TABLE t.test ( x INT PRIMARY KEY, y INT NOT NULL, z INT, a INT, b INT, c INT, d INT, FAMILY (x), FAMILY (y), FAMILY (z),
I think a comment briefly explaining what the logic is for these column families would be helpful.
The existing operations test did not catch various bugs uncovered in cockroachdb#45347, so this test expands upon the existing schema change operations tests with a larger test case. Release justification: non production code change Release note: None
Contributor
Author
|
bors r=lucy-zhang |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing operations test did not catch various bugs
uncovered in #45347, so this test expands upon the existing
schema change operations tests with a larger test case.
Release note: None