Skip to content

ui: Set react component key prop to fix react errors#45642

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
koorosh:ui-fix-react-dev-errors
Mar 6, 2020
Merged

ui: Set react component key prop to fix react errors#45642
craig[bot] merged 1 commit intocockroachdb:masterfrom
koorosh:ui-fix-react-dev-errors

Conversation

@koorosh
Copy link
Copy Markdown
Contributor

@koorosh koorosh commented Mar 3, 2020

Set react component key prop to fix react errors

Resolves: #45188

@koorosh koorosh requested a review from a team March 3, 2020 14:22
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@koorosh koorosh force-pushed the ui-fix-react-dev-errors branch from 7371f6d to b0d9b39 Compare March 4, 2020 09:33
Copy link
Copy Markdown
Contributor

@nathanstilwell nathanstilwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanstilwell
Copy link
Copy Markdown
Contributor

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 5, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 6, 2020

Build succeeded

@craig craig bot merged commit 875052e into cockroachdb:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: Eliminate React errors from missing key props in test runs

3 participants