ui: standardize the display of node names in node lists#45551
ui: standardize the display of node names in node lists#45551craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Standardize the display of node names in node lists. The nodes overview list was displaying nodes as `N<id> <ip-address>` while graphs display `<ip-address> (n<id>)`. Standardize on the latter format. A similar problem existed on the statement details page which was displaying `N<id> <ip-address> (n<id>)`. The node id was being displayed twice! Release note: None
|
This change is |
petermattis
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/ui/src/views/cluster/containers/nodesOverview/index.tsx, line 131 at r1 (raw file):
return ( <Link className="nodes-table__link" to={`/node/${record.nodeId}`}> <Text>{record.nodeName}</Text>
Why does nodeName not include the (n<id>) suffix? Should we be using getDisplayName to populate nodeName?
|
Thanks for this @petermattis! I think I'll merge as-is for now. I agree something like @Annebirzin see Peter's comment above for the changes he made to the node naming. Let me know if there's a strong reason to use the Nx prefix notation for nodes. Otherwise I think consistency is preferred for now. cc @taroface hopefully if this is intersecting with any docs work it's making your life easier :) |
|
bors r+ |
Build succeeded |
|
@dhartunian 👍 makes sense, we can standardize to |
I have a strong preference for |
Standardize the display of node names in node lists. The nodes overview
list was displaying nodes as
N<id> <ip-address>while graphs display<ip-address> (n<id>). Standardize on the latter format. A similarproblem existed on the statement details page which was displaying
N<id> <ip-address> (n<id>). The node id was being displayed twice!Release note: None