storage/engine: micro-optimize MVCCKeyCompare#45462
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 26, 2020
Merged
storage/engine: micro-optimize MVCCKeyCompare#45462craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
`MVCCKeyCompare` is the single largest CPU usage function in a `tpccbench` test. So give it a bit of micro-optimization love. While we're here, move this function next to the rest of the Pebble code as that is the main user. name old time/op new time/op delta MVCCKeyCompare-16 15.8ns ± 4% 9.1ns ± 1% -42.57% (p=0.000 n=10+10) Release note: None
Member
|
This change is |
itsbilal
approved these changes
Feb 26, 2020
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)
Collaborator
Author
|
TFTR! bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVCCKeyCompareis the single largest CPU usage function in atpccbenchtest. So give it a bit of micro-optimization love. Whilewe're here, move this function next to the rest of the Pebble code as
that is the main user.
name old time/op new time/op delta
MVCCKeyCompare-16 15.8ns ± 4% 9.1ns ± 1% -42.57% (p=0.000 n=10+10)
Release note: None