release-19.2: colexec: skip over unneeded columns with unknown types in cfetcher#42934
Merged
asubiotto merged 2 commits intocockroachdb:release-19.2from Dec 7, 2019
asubiotto:backport19.2-42616
Merged
release-19.2: colexec: skip over unneeded columns with unknown types in cfetcher#42934asubiotto merged 2 commits intocockroachdb:release-19.2from asubiotto:backport19.2-42616
asubiotto merged 2 commits intocockroachdb:release-19.2from
asubiotto:backport19.2-42616
Conversation
Member
|
This change is |
Member
|
[nit]: Also, there is a related test failure (#37815 (comment)), so I would hold off on backporting until we figure out the cause of that issue. I'll dig in today. |
Contributor
Author
|
Thanks, will wait for that to merge and add it to this PR |
Previously, we would return an error if we encountered an unknown type in the cfetcher, even if the values from the column were never decoded into the output coldata.Batch. This change supports reading from a table with unknown types as long as those columns are marked as not needed. The approach this patch takes is to allow a coldata.Batch to be created with unknown types, but disallowing any uses of unknown type Vecs, other than observing that it is of unknown type. Release note (sql change): Vectorized queries that execute only on supported types even if those types form part of a table with unsupported types are now run through the vectorized engine. This would previously fall back to the row-by-row execution engine.
We recently merged a change to allow for 'unknown' vectors to be present among colvecs. However, we forgot to update the resetting of the batch - unknown columns do not have nulls and don't need to be reset. Now this is fixed. Also this commit removes an unused field in cfetcher. Release note: None
Contributor
Author
Contributor
Author
|
Actually, we should backport this first and then @rohany's changes |
Contributor
|
LGTM |
yuzefovich
approved these changes
Dec 7, 2019
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 5 of 8 files at r1, 3 of 3 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rohany)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would return an error if we encountered an unknown type in the
cfetcher, even if the values from the column were never decoded into the output
coldata.Batch. This change supports reading from a table with unknown types as
long as those columns are marked as not needed. The approach this patch takes
is to allow a coldata.Batch to be created with unknown types, but disallowing
any uses of unknown type Vecs, other than observing that it is of unknown type.
Release note (sql change): Vectorized queries that execute only on supported
types even if those types form part of a table with unsupported types are now
run through the vectorized engine. This would previously fall back to the
row-by-row execution engine.