sql,sqlbase: finish the migration to use MVCC timestamps with table descriptors#42655
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 1, 2020
Conversation
Member
|
This change is |
Contributor
Author
|
@dt I looked at stripping timestamps from the helper functions which construct table descriptors and hit some snags touching some restore code. Are you cool with this less involved change? cc @lucy-zhang |
Contributor
I'm not really keeping up with tabledesc mgmt anymore so I'm going to leave this up to Lucy and sql folk. |
thoszhang
approved these changes
Jan 14, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Sorry for the delay.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
TFTR! bors r=lucy-zhang |
Contributor
Build failed (retrying...) |
Contributor
Build failed |
d20f78b to
6da9b77
Compare
…escriptors In cockroachdb#40581 we changed the protocol for creating and updating table descriptors to no longer serialize the hlc timestamp at which the descriptor was created or modified directly into the value but rather to infer it from the MVCC timestamp of the row. For backwards compatibility we left a migration in place. This commit finishes the migration. Release note: None.
6da9b77 to
4b56a6a
Compare
Contributor
Author
|
bors r+ for real this time, cannot believe this has sat since January |
Contributor
|
Already running a review |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #40581 we changed the protocol for creating and updating table descriptors
to no longer serialize the hlc timestamp at which the descriptor was created
or modified directly into the value but rather to infer it from the MVCC
timestamp of the row. For backwards compatibility we left a migration in
place. This commit finishes the migration.
Release note: None.