[DNM] protectedts: introduce a protected timestamp subsystem#41996
Closed
ajwerner wants to merge 6 commits intocockroachdb:masterfrom
Closed
[DNM] protectedts: introduce a protected timestamp subsystem#41996ajwerner wants to merge 6 commits intocockroachdb:masterfrom
ajwerner wants to merge 6 commits intocockroachdb:masterfrom
Conversation
added 6 commits
October 29, 2019 11:41
This commit introduces the interfaces for the protectedts subsystem. Release note: None
This commit implements the storage layer of the protectedts subsystem on top of kvs in the database. It uses a single, constant meta key to serialize all updates. This will enable caching in the Tracker implementation. This approach will lead to contention problems if many protected timestamps are being created concurrently. Read locks will help. Release note: None.
The Tracker periodically polls the protectedts state. This is made cheap through the use of the meta key. Release note: None
…e package This commit does several things: 1) Introduces AdminVerifyProtectedTimestamp api 2) Adopts the protectedts.Tracker in the storage gc queue 3) Constructs and plumbs a protectedts.Provider through the server Release note: None
This commit adds logic to verify that a protectedts record has successfully protected its intended target. Release note: None
This commit adds a very simple end-to-end test of the protectedts subsystem. Release note: None
Contributor
Author
|
This is out ahead of the RFC in #43806 but I'll update that to reflect this work soon. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP PR comes in 6 commits:
Storageinterface on top of the KV store, defines the relevant keys and system tablesTrackerinterface to poll the state of the subsystem, for consumption by the GC queue