partitionccl: various improvements to TestRepartitioning#41240
Closed
ajwerner wants to merge 2 commits intocockroachdb:masterfrom
Closed
partitionccl: various improvements to TestRepartitioning#41240ajwerner wants to merge 2 commits intocockroachdb:masterfrom
ajwerner wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
b6655d0 to
29f6091
Compare
added 2 commits
October 1, 2019 20:07
Prior to this commit the partitioning tests worked by creating a 3 node cluster and then expressed constraints over the three nodes. It then validates that the cluster conforms to the constraints by querying data and examining the trace to determine which node held the data. This is problematic for one because it is succeptible to cockroachdb#40333. In rare cases we'll down-replicate to the wrong single node (e.g. if the right one is not live) and we won't ever fix it. It also doesn't exercise leaseholder preferences. This PR adds functionality to configure clusters with larger numbers of nodes where each expectation in the config can now refer to a leaseholder_preference rather than a constraint and we'll allocate the additional nodes to 3 datacenters. This larger test creates dramatically more data movement and has been useful when testing cockroachdb#40892. The PR also adds a flag to control how many of these subtests to run. Release justification: Only touches testing and is useful for testing a release blocker. Release note: None
This PR extends the partition test to sometimes start as a 19.1 cluster and upgrade to 19.2. This test will age poorly valuable during the transition. This form of testing will only remain active on the 19.1 branch and should be removed from 20.1 when that happens. It's sort of too little, too late but it's now typed and I hope will remain valuable for the remainder of this release. Release justification: testing only. Release note: None
29f6091 to
6d77677
Compare
Contributor
Author
|
Closing in favor of #42758 which just includes the first commit. The second commit is no longer relevant. Perhaps we could backport the first commit to 19.2 and then add the second commit but it's not obviously worth it presently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two commits:
Release Justification: just testing.