util/log: properly detect when crash reporting is disabled#35823
Closed
knz wants to merge 1 commit intocockroachdb:masterfrom
Closed
util/log: properly detect when crash reporting is disabled#35823knz wants to merge 1 commit intocockroachdb:masterfrom
knz wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Release note: None
Member
|
This change is |
Contributor
Author
|
Subsumed by #35820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing internal errors with #35820 and SQL logic tests and I ran into a goroutine leak of
raven.Client. I was like - that can't be right! SQL logic tests should run with reporting disabled.Indeed, it "disables" reporting by not running
raven.SetDSNhoweverraven.DefaultClientis non-nil by default. So the existing check was incorrect.Release note: None