githooks: update the release note recommendations#29810
Closed
knz wants to merge 1 commit intocockroachdb:masterfrom
Closed
githooks: update the release note recommendations#29810knz wants to merge 1 commit intocockroachdb:masterfrom
knz wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
92267e3 to
7497c23
Compare
Release note: None
7497c23 to
2815470
Compare
jseldess
reviewed
Sep 8, 2018
Contributor
jseldess
left a comment
There was a problem hiding this comment.
Thanks for moving so quickly on this, @knz. I'm OOO on Monday, but I'll get you thorough comments on Tuesday.
Reviewable status:
complete! 0 of 0 LGTMs obtained
Contributor
Author
|
This has been addressed elsewhere since. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the followup to our conversation earlier this week. Independently of the order in which we'll list the sections, I would like to start the motion to:
My draft at a proposal is included here in the form of a PR to our default commit messages. We can iterate on this with the benefit of reviewable and source control.
Should we reach an agreement, this PR alone will not be the end of it: we will also need: