workload/tpcc: use explicit primary key in tpcc.history#23827
workload/tpcc: use explicit primary key in tpcc.history#23827petermattis merged 1 commit intocockroachdb:masterfrom
Conversation
|
Heh, I hit a duplicate key violation when generating a tpcc-10k dataset: I see two options here: I can tweak the generation of these random rowids, or I can switch to using a UUID. The latter is what we'd recommend for production use. Let me see how bad it is. |
d814c08 to
111dba2
Compare
|
Ok, this is ready for another look. Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. pkg/workload/tpcc/ddls.go, line 72 at r1 (raw file):
@jordanlewis Comments from Reviewable |
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. pkg/workload/tpcc/ddls.go, line 72 at r1 (raw file): Previously, petermattis (Peter Mattis) wrote…
Use Comments from Reviewable |
111dba2 to
d98cd6d
Compare
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. pkg/workload/tpcc/ddls.go, line 72 at r1 (raw file): Previously, jordanlewis (Jordan Lewis) wrote…
Done. Unfortunate that we have 2 functions that or so similar except in their return type (and names). Comments from Reviewable |
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending. pkg/workload/tpcc/ddls.go, line 72 at r1 (raw file): Previously, petermattis (Peter Mattis) wrote…
Yeah - Comments from Reviewable |
Use an explicit UUID primary key in tpcc.history. Fixes cockroachdb#23544 Release note: None
d98cd6d to
904aff7
Compare
Use an explicit primary key in tpcc.history which is identical to the
implicit one. When generating fixture data, fill in the rowid using a
random 63-bit integer rather than relying on sequential values generated
during import. This matches the rowid generation used by the
tpccloadgenerator.
Fixes #23544
Release note: None