storage: Disallow sync intent resolution in loadSystemConfig#23282
Merged
bdarnell merged 1 commit intocockroachdb:masterfrom Mar 1, 2018
Merged
storage: Disallow sync intent resolution in loadSystemConfig#23282bdarnell merged 1 commit intocockroachdb:masterfrom
bdarnell merged 1 commit intocockroachdb:masterfrom
Conversation
This holds raftMu on the system config range for too long, and in extreme cases can lead to deadlock. Fixes cockroachdb#23254 Release note (bug fix): Fixed a deadlock when tables are rapidly created or dropped.
Member
|
This change is |
a-robinson
approved these changes
Mar 1, 2018
Contributor
a-robinson
left a comment
There was a problem hiding this comment.
Well that was bad. LGTM.
Member
|
LGTM but we should exercise this in |
Member
|
(also not that you'd forget, but let's cherry-pick that) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This holds raftMu on the system config range for too long,
and in extreme cases can lead to deadlock.
Fixes #23254
Release note (bug fix): Fixed a deadlock when tables are rapidly
created or dropped.