Skip to content

sql: add some missing pgerror codes#23146

Merged
knz merged 1 commit intocockroachdb:masterfrom
knz:20180227-add-missing-pgerrors
Feb 27, 2018
Merged

sql: add some missing pgerror codes#23146
knz merged 1 commit intocockroachdb:masterfrom
knz:20180227-add-missing-pgerrors

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Feb 27, 2018

Requested/suggested by @nvanbenschoten

Release note: none

@knz knz requested review from a team and nvb February 27, 2018 10:56
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@jordanlewis
Copy link
Copy Markdown
Member

:lgtm: assuming these in fact correspond to the equivalent in pg. Thanks!


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

Requested/suggested by @nvanbenschoten

Release note: none
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Feb 27, 2018

I went and checked, and all but the first cannot occur in pg at all (specific to cockroachdb).

@knz knz force-pushed the 20180227-add-missing-pgerrors branch from 6fe4609 to a88e6a4 Compare February 27, 2018 15:11
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Feb 27, 2018

thanks!

@knz knz merged commit ca8e7d6 into cockroachdb:master Feb 27, 2018
@knz knz deleted the 20180227-add-missing-pgerrors branch April 27, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants