sql: add more info to advanceInfo#22367
Merged
andreimatei merged 1 commit intocockroachdb:masterfrom Feb 8, 2018
Merged
Conversation
Member
|
This change is |
Contributor
Author
|
extracted from #22277 |
c378bb0 to
ab9763b
Compare
This was referenced Feb 4, 2018
advanceInfo is the structure produced by the connection state machine when processing events. Its main purpose is to tell the connExecutor what statement to execute next (the next one, the same one again, jump to the next batch). This patch add another nugget of information - a "transaction event" telling the connEx if a couple of things happened to the SQL transaction as a result of the state machine event that was just processed. The idea is that these txn events will be used to know if we should run or clear transactional state maintained by the connEx, such as the schema changes. The txn events can be seen as a much-distilled version of the state machine events, much more suitable for consumption by the connEx. Release note: None
ab9763b to
27bf94c
Compare
Contributor
|
Reviewed 5 of 5 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Contributor
|
The code here LGTM, but I'm still not sure why we're setting txnState on advanceInfo. What decisions is the state going to help inform? Reviewed 2 of 5 files at r1. Comments from Reviewable |
Contributor
Author
|
I believe I got a verbal LGTM for the N-man. Merging. Review status: Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
advanceInfo is the structure produced by the connection state machine
when processing events. Its main purpose is to tell the connExecutor
what statement to execute next (the next one, the same one again, jump
to the next batch). This patch add another nugget of information - a
"transaction event" telling the connEx if a couple of things happened to
the SQL transaction as a result of the state machine event that was just
processed. The idea is that these txn events will be used to know if we
should run or clear transactional state maintained by the connEx, such
as the schema changes. The txn events can be seen as a much-distilled
version of the state machine events, much more suitable for consumption
by the connEx.
Release note: None