libroach: add encoding tests#20595
Merged
benesch merged 1 commit intocockroachdb:masterfrom Dec 9, 2017
Merged
Conversation
Member
|
This change is |
9bb1a62 to
088adf2
Compare
Contributor
|
LGTM! |
mberhault
reviewed
Dec 9, 2017
build/teamcity-check.sh
Outdated
| # teamcity-test.sh, but we do it here to minimize total build time since the | ||
| # rest of this script completes much faster than teamcity-test.sh. | ||
| build/builder.sh make -C pkg/ui | ||
| build/builder.sh make check-libroach |
Contributor
There was a problem hiding this comment.
this is a little weird though. It means the libroach tests get run in the lint built.
Complete a TODO now that cgo is no longer in the way. This paves the way for future libroach tests. Release note: None
088adf2 to
f31ec3f
Compare
Contributor
Author
|
Ok, moved to test build! |
Contributor
|
Thanks. LGTM again. I'll add the gtest portion after this goes in. |
Contributor
Author
|
Perfect, sounds good! |
Contributor
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete a TODO now that cgo is no longer in the way. This paves the way
for future libroach tests.
Release note: None