WIP: cli: add enterprise-encryption flag.#20260
Closed
mberhault wants to merge 1 commit intocockroachdb:masterfrom
Closed
WIP: cli: add enterprise-encryption flag.#20260mberhault wants to merge 1 commit intocockroachdb:masterfrom
mberhault wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
29 tasks
5e91c5c to
6691488
Compare
Part of encryption-at-rest work. Add a CCL-only `--enterprise-encryption` flag (does not show up on OSS builds) that adds arbitrary fields to the store spec. This is a bit tortuous as we need to: * modify the startCmd flags (startCmd made public) * run an extra PreRun hook (added custom extra hook) * access the store specs from CCL code (serverCfg made public) * have a generic enough datastructure in `StoreSpec` Some of these can be generalized. eg: * accessing all commands from CCL code (including flag formatting) * allow arbitrary number of additional hooks per command How to hook those up into libroach is still TBD. These flags will control at least two things: * the store version (only bumped if those flags are set) * the use of encryption in libroachccl
6691488 to
5f7f3ad
Compare
Contributor
Author
|
Picking sha into #20225. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of encryption-at-rest work.
Add a CCL-only
--enterprise-encryptionflag (does not showup on OSS builds) that adds arbitrary fields to the store spec.
This is a bit tortuous as we need to:
StoreSpecSome of these can be generalized. eg:
How to hook those up into libroach is still TBD. These flags will
control at least two things: