storage: Convert 'nodeStatus' enumeration to proto#20086
Merged
mrtracy merged 1 commit intocockroachdb:masterfrom Nov 16, 2017
Merged
storage: Convert 'nodeStatus' enumeration to proto#20086mrtracy merged 1 commit intocockroachdb:masterfrom
mrtracy merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
|
Reviewed 6 of 6 files at r1. pkg/storage/liveness.proto, line 54 at r1 (raw file):
Why not 4? Comments from Reviewable |
Contributor
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. Comments from Reviewable |
Contributor
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. Comments from Reviewable |
Converts the nodeStatus enumeration (used by the store pool and allocator) to a protocol buffer. The purpose is that we intend to expose this information the Admin UI in a subsequent commit. Works towards cockroachdb#17840
4260be5 to
c877486
Compare
Contributor
Author
|
Review status: 4 of 6 files reviewed at latest revision, 1 unresolved discussion. pkg/storage/liveness.proto, line 54 at r1 (raw file): Previously, a-robinson (Alex Robinson) wrote…
https://youtu.be/xOrgLj9lOwk?t=128 Fixed Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the nodeStatus enumeration (used by the store pool and
allocator) to a protocol buffer. The purpose is that we intend to expose
this information the Admin UI in a subsequent commit.
Works towards #17840