sql: add transaction_read_only variable#19966
Merged
knz merged 1 commit intocockroachdb:masterfrom Nov 10, 2017
Merged
Conversation
Member
|
This change is |
Contributor
|
Very good. Solid change. LGTM. Thanks for your contribution! |
Contributor
|
It actually looks to me like when this is not true PG outputs "off" rather than "false": I should have checked this before opening the original issue, but could we fix this to match that behaviour? |
Contributor
Author
|
You are correct, I just tested on 9.6 as well and totally missed that. Let me update the PR. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19911. @justinj this should address adding the read-only transaction_read_only variable.